#61 open
zachriggle

Crash: Right-left click on tab

Reported by zachriggle | December 24th, 2010 @ 07:47 AM | in 0.1 — first usable version

What I did

Quickly right-click then left-click on a tab. Clicking furiously with both buttons does the trick, but it appears that a single combo of right-left is the culprit.

What I expected to happen

Not a crash

What actually happened

Crash

Remarks

Clicking just left-click a bunch of times, or just right-click a bunch of times does not cause a crash.

Comments and changes to this ticket

  • rsms

    rsms December 24th, 2010 @ 04:54 PM

    • Milestone set to 0.1 — first usable version
    • State changed from “new” to “open”
    • Assigned user set to “rsms”
    • Tag set to bug, crash, ui
    • Milestone order changed from “43” to “0”

    I'm unable to reproduce this with my laptop, but will try with a proper mouse when I get home after the holidays.

  • John Bradley

    John Bradley February 15th, 2011 @ 06:12 AM

    There seemed to have been a bug in CTTabView.mm where a call to WLOG with format specifier %@ was used with an argument of type (int)NSEventType.

    In the case of the crash the value was 0x4. Changing the specifier to %d or %i should resolve the problem as is done in the following branch.

    https://github.com/kc5nra/chromium-tabs/tree/61-crash-right-left-cl...

  • John Bradley

    John Bradley February 15th, 2011 @ 07:45 AM

    Just a follow up on why that path in the if statement is even taken...

    From what I can tell is it's a bug in the nextEventMatchingMask method. Since technically the NSLeftMouseDraggedMask is still active (you are dragging the mouse) it is catching erroneously(?) the up events from other buttons.

    To reproduce this one doesn't have to be "fast" at all, but just holding the left mouse button down and then right clicking will cause the eventMatchingMask to catch seemingly inappropriate NSEvents. If you have a mouse with more than left and right, it will catch NSOtherMouseUp.

    My only somewhat reasonable conclusion is that the original developers didn't run into this due to typical Mac environments having a single button (not two physically separate buttons) mouse and the fact that it can easily be ignored (as is being done now).

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

A text editor for Mac OS X

People watching this ticket

Tags

Pages